Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mb03rd wrapper: schur to block-diagonal transform #116

Merged
merged 2 commits into from
May 3, 2020
Merged

Add mb03rd wrapper: schur to block-diagonal transform #116

merged 2 commits into from
May 3, 2020

Conversation

bnavigator
Copy link
Collaborator

This is based on #73 by @repagh, but rebased to current master with the following modifications:

  • moved to math instead of transform
  • only one wrapper function for both jobx values
  • only one return signature: return Xr = None for jobx='N'
  • eigenvalues returned as complex ndarray
  • unit test tests for all job parameters
  • check the returned complex eigenvalues
  • docstring in Numpydoc with almost all of the FORTRAN docstring

@bnavigator
mb03rd schur to block-diagonal transform
fcf4396 
Based on PR python-control#73 by @repagh

Moved from transform to math
single wrapper for all jobx parameter valies
docstring in numpydoc (python-control#100)
run all jobx and sort parameter values in test
check the returned complex eigenvalues in test
@repagh repagh mentioned this pull request May 3, 2020
Closed
@repagh repagh merged commit c8d3a21 into python-control:master May 3, 2020
@repagh repagh mentioned this pull request May 3, 2020
Closed
@bnavigator bnavigator deleted the mb03rd branch December 31, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnavigator @repagh