-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numpy 1.24 breaks compiling Slycot #187
Numpy 1.24 breaks compiling Slycot #187
Comments
FWIW, with numpy 1.23.5, diff --git a/slycot/src/analysis.pyf b/slycot/src/analysis.pyf
index 633ff6e..9945ca0 100644
--- a/slycot/src/analysis.pyf
+++ b/slycot/src/analysis.pyf
@@ -11,7 +11,7 @@ subroutine ab01nd(jobz,n,m,a,lda,b,ldb,ncont,indcon,nblk,z,ldz,tau,tol,iwork,dwo
integer intent(out) :: indcon
integer intent(out),dimension(n),depend(n) :: nblk
double precision intent(out),dimension(ldz,n),depend(n,ldz) :: z
- integer intent(hide),depend(n, jobz) :: ldz = (*jobz == 'N' ? 1 : n)
+ integer intent(hide),depend(n, jobz) :: ldz = (jobz == 'N' ? 1 : n)
double precision intent(out),dimension(n),depend(n) :: tau
double precision :: tol = 0
integer intent(hide,cache),dimension(m),depend(m) :: iwork There is something wrong with my setup, though, since with or without the above, I presume numpy 1.24 must be installed from PyPI, I haven't tried that yet. |
hm, I was too hasty; maybe the tests are incomplete?
|
with this diff, both tests in test_mb03rd fail.
|
remove numpy pins fixes python-controlgh-187
https://build.opensuse.org/request/show/1044040 by user bnavigator + dimstar_suse - Update to 0.5.3 * This patch release updates the build system to be compatible with NumPy 1.24.0 -- gh#python-control/Slycot#187 - Drop rpmlintc: python-tests-in-package has been dropped
Numpy 1.24.0 came out a few hours ago and broke compiling the Fortran wrappers.
The text was updated successfully, but these errors were encountered: