Skip to content

Commit

Permalink
Use pip install in conda-build recipes
Browse files Browse the repository at this point in the history
This is recommended by conda-forge; see [1].  It also tests "pip
installability".

[1] http://conda-forge.org/docs/maintainer/adding_pkgs.html#use-pip
  • Loading branch information
roryyorke committed Jun 22, 2019
1 parent f5c35e3 commit 2894c98
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 4 deletions.
2 changes: 1 addition & 1 deletion conda-recipe-openblas/bld.bat
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ if EXIST "%PREFIX%\Scripts\f2py.exe" (
set F2PY=%PREFIX%\Scripts\f2py.bat
)

"%PYTHON%" setup.py install
"%PYTHON%" -m pip install . --no-deps --ignore-installed -vv

if errorlevel 1 exit 1

Expand Down
3 changes: 2 additions & 1 deletion conda-recipe-openblas/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,5 @@ export LAPACK_ROOT=${PREFIX}
rm -rf _skbuild

# do the build
$PYTHON setup.py install
$PYTHON -m pip install . --no-deps --ignore-installed -vv

2 changes: 2 additions & 0 deletions conda-recipe-openblas/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ build:
string: py{{ environ.get('PY_VER').replace('.', '') }}{{ environ.get('GIT_DESCRIBE_HASH', '') }}_obl_{{ environ.get('GIT_DESCRIBE_NUMBER', 0) }}

requirements:
# TODO: pip possibly required in only *one* of build and host, but which?
build:
- python {{ PY_VER }}
- numpy
Expand All @@ -21,6 +22,7 @@ requirements:

host:
- python {{ PY_VER }}
- pip
- flang # [win]
- numpy
- openblas >=0.3.0
Expand Down
2 changes: 1 addition & 1 deletion conda-recipe/bld.bat
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ if EXIST "%PREFIX%\Scripts\f2py.exe" (
set F2PY=%PREFIX%\Scripts\f2py.bat
)

"%PYTHON%" setup.py install
"%PYTHON%" -m pip install . --no-deps --ignore-installed -vv

if errorlevel 1 exit 1

Expand Down
2 changes: 1 addition & 1 deletion conda-recipe/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ rm -rf _skbuild
env

# do the build
$PYTHON setup.py install
$PYTHON -m pip install . --no-deps --ignore-installed -vv
2 changes: 2 additions & 0 deletions conda-recipe/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ requirements:
# conda-supplied clang and library linking see e.g.
# https://github.com/conda-forge/mpi-feedstock issue #4
# conda-forge might have the configuration in place for clang build and link?
# TODO: pip possibly required in only *one* of build and host, but which?
build:
- python {{PY_VER}}
- numpy
Expand All @@ -24,6 +25,7 @@ requirements:

host:
- python {{ PY_VER }}
- pip
- flang # [win]
- numpy
- mkl
Expand Down

0 comments on commit 2894c98

Please sign in to comment.