Make BaseValidationError base static in Python < 3.11
#379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unsure if this worked in MyPy but Pyright failed to resolve the base of `BaseValidationError` subclasses leading to hard to trace type errors in custom note attributes from failing to narrow Iterable and ClassValidationError unions.
Contributor
Author
|
Because |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #379 +/- ##
==========================================
- Coverage 95.80% 94.38% -1.42%
==========================================
Files 26 26
Lines 2121 2120 -1
==========================================
- Hits 2032 2001 -31
- Misses 89 119 +30
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure if this worked in MyPy but Pyright failed to resolve the base of
BaseValidationErrorsubclasses leading to hard to trace type errors in custom note attributes from failing to narrow Iterable and ClassValidationError unions.