-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed toolz
, potential bugfixes, perfomance improvements, and more
#43
base: main
Are you sure you want to change the base?
Conversation
Thanks for the contribution! I'm pretty busy right now, so I might not get a chance to review this in the next few days, but the changes sound great, so I definitely do want to review it sooner than later. |
@brandonwillard Except for a few (reasonable) exceptions, each commit is limited to the changes of one function. |
I noticed that this repo was being used by some big performance-focused projects (e.g. pymc), so I figured I'd take a look at the code. So, apparantly, this is the result of me "looking" at the code 🤷🏻♂️ :
toolz
, by rewritingmatch.ordering
using a (faster) dict comprehensionutil._toposort
variable.Var
instance check==
comparison oftype
'score.assoc
utils.freeze
util.transitive_get
try:
blocks... and I'm sure I'm forgetting some stuff 😅