This repository was archived by the owner on May 6, 2025. It is now read-only.
Update getUpdateFee signature to take updateData #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantk
previously approved these changes
Oct 17, 2022
Contributor
jayantk
left a comment
jayantk
left a comment
There was a problem hiding this comment.
I think you should make the version 2.0, but i don't feel strongly.
jayantk
approved these changes
Oct 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
getUpdateFeeto get the whole updateData. The underlying logic is the same but it might change in the future and this changes makes it future proof (so we can use some other information from the updataData)Also, bumps the version to
2.0.0as it is a breaking change.