This repository was archived by the owner on May 6, 2025. It is now read-only.
Abehjati/refactor-interface-release #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PriceFeed is more concise this way. Also querying requires less gas. - Also use uint for time (as it is the eth used type for time)
jayantk
previously approved these changes
Sep 20, 2022
Contributor
jayantk
left a comment
jayantk
left a comment
There was a problem hiding this comment.
left a couple documentation comments but not a big deal to merge without fixing. We can do a pass on all the docs later.
jayantk
approved these changes
Sep 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the PriceFeed struct to make it more concise.
Also improves the interface with some small changes.