feat(dev-hub) Include feeds in the search #3211
Merged
+118
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
cprussin
approved these changes
Nov 19, 2025
Collaborator
cprussin
left a comment
cprussin
left a comment
There was a problem hiding this comment.
Nice, great work! Minor suggestions to help make the code a bit cleaner but up to you if you care to implement them.
Comment on lines
26
to
60
| const endpoints = [ | ||
| "https://hermes.pyth.network", | ||
| "https://hermes-beta.pyth.network", | ||
| ]; | ||
| const responses = await Promise.all( | ||
| endpoints.map((url) => | ||
| fetch(`${url}/v2/price_feeds`, { | ||
| next: { revalidate: 3600 }, | ||
| }).then((res) => res.json() as Promise<unknown>), | ||
| ), | ||
| ); | ||
|
|
||
| const allFeeds: AdvancedIndex[] = []; | ||
|
|
||
| for (const data of responses) { | ||
| const parsed = hermesSchema.safeParse(data); | ||
| if (parsed.success) { | ||
| for (const feed of parsed.data) { | ||
| allFeeds.push({ | ||
| title: `${feed.attributes.symbol} (Core)`, | ||
| description: `Price Feed ID: ${feed.id}`, | ||
| url: `/price-feeds/core/price-feeds/price-feed-ids?search=${feed.attributes.symbol}`, | ||
| id: feed.id, | ||
| tag: "price-feed-core", | ||
| structuredData: { | ||
| headings: [], | ||
| contents: [ | ||
| { heading: "Symbol", content: feed.attributes.symbol }, | ||
| { heading: "ID", content: feed.id }, | ||
| ], | ||
| }, | ||
| }); | ||
| } | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Suggested change
| const endpoints = [ | |
| "https://hermes.pyth.network", | |
| "https://hermes-beta.pyth.network", | |
| ]; | |
| const responses = await Promise.all( | |
| endpoints.map((url) => | |
| fetch(`${url}/v2/price_feeds`, { | |
| next: { revalidate: 3600 }, | |
| }).then((res) => res.json() as Promise<unknown>), | |
| ), | |
| ); | |
| const allFeeds: AdvancedIndex[] = []; | |
| for (const data of responses) { | |
| const parsed = hermesSchema.safeParse(data); | |
| if (parsed.success) { | |
| for (const feed of parsed.data) { | |
| allFeeds.push({ | |
| title: `${feed.attributes.symbol} (Core)`, | |
| description: `Price Feed ID: ${feed.id}`, | |
| url: `/price-feeds/core/price-feeds/price-feed-ids?search=${feed.attributes.symbol}`, | |
| id: feed.id, | |
| tag: "price-feed-core", | |
| structuredData: { | |
| headings: [], | |
| contents: [ | |
| { heading: "Symbol", content: feed.attributes.symbol }, | |
| { heading: "ID", content: feed.id }, | |
| ], | |
| }, | |
| }); | |
| } | |
| } | |
| } | |
| const [hermesFeeds, hermesBetaFeeds] = await Promise.all( | |
| [HERMES_URL, HERMES_BETA_URL].map((url) => { | |
| const hermesResult = await fetch(new URL('/v2/price_feeds', url), { | |
| next: { revalidate: 3600 }, | |
| }); | |
| const parsed = hermesSchema.safeParse(await hermesResult.json()); | |
| return parsed.success | |
| ? parsed.data.map(feed => toAdvancedIndex(feed)) | |
| : undefined | |
| }) | |
| ); | |
| return [...hermesFeeds, ...hermesBetaFeeds]; |
And then just add a toAdvancedIndex: (fee: z.infer<typeof hermesSchema>[number]) => AdvancedFeed function.
Simpler, requires less procedural / mutable object building, and keeps processing close to data fetching.
Comment on lines
74
to
75
| const data = (await res.json()) as unknown; | ||
| const parsed = lazerSchema.safeParse(data); |
Collaborator
There was a problem hiding this comment.
Suggested change
| const data = (await res.json()) as unknown; | |
| const parsed = lazerSchema.safeParse(data); | |
| const parsed = lazerSchema.safeParse(await res.json()); |
Little trick when using zod schemas with fetch that avoids the awkward need to typecast to unknown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
How has this been tested?