feat(hip-3-pusher): Mark price support #3206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tejasbadadare
approved these changes
Nov 19, 2025
Comment on lines
+133
to
+147
| def get_price_from_oracle_mid_average(self, symbol: str, oracle_update: OracleUpdate): | ||
| oracle_price = oracle_update.oracle.get(symbol) | ||
| if oracle_price is None: | ||
| return None | ||
|
|
||
| mid_price_update: PriceUpdate | None = self.hl_mid_state.get(symbol) | ||
| if mid_price_update is None: | ||
| logger.warning("mid price for {} is missing", symbol) | ||
| return None | ||
| time_diff = mid_price_update.time_diff(time.time()) | ||
| if time_diff >= self.stale_price_threshold_seconds: | ||
| logger.warning("mid price for {} is stale by {} seconds", symbol, time_diff) | ||
| return None | ||
|
|
||
| return (float(oracle_price) + float(mid_price_update.price)) / 2.0 |
Contributor
There was a problem hiding this comment.
the logic is simple for now, but maybe you want to generate a quick unit test anyway?
Contributor
Author
There was a problem hiding this comment.
As per Slack discussion, need to improve testing, will put in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support mark price as mean(oracle, mid).
Rationale
How has this been tested?