Skip to content

Conversation

alexcambose
Copy link
Contributor

Description

Type of Change

  • New Page
  • Page update/improvement
  • Fix typo/grammar
  • Restructure/reorganize content
  • Update links/references
  • Other (please describe):

Areas Affected

Checklist

  • I ran pre-commit run --all-files to check for linting errors
  • I have reviewed my changes for clarity and accuracy
  • All links are valid and working
  • Images (if any) are properly formatted and include alt text
  • Code examples (if any) are complete and functional
  • Content follows the established style guide
  • Changes are properly formatted in Markdown
  • Preview renders correctly in development environment

Related Issues

Closes #

Additional Notes

Contributor Information

  • Name:
  • Email:

Screenshots

@vercel
Copy link

vercel bot commented Oct 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Ready Ready Preview Comment Oct 21, 2025 11:31am
documentation Error Error Oct 21, 2025 11:31am

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

Comment on lines +132 to +133
"/price-feeds/use-real-time-data/:path((?!pull-integration(?:/|$)).*)",
"/price-feeds/use-real-time-data/pull-integration/:path",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aditya520 note that this has 2 cases:
http://localhost:3000/price-feeds/use-real-time-data redirects to http://localhost:3000/price-feeds/core/use-real-time-data

and

http://localhost:3000/price-feeds/use-real-time-data/something -> http://localhost:3000/price-feeds/use-real-time-data/pull-integration/something

I'm not sure if that's the intended behaviour

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second one should be

http://localhost:3000/price-feeds/use-real-time-data/something -> http://localhost:3000/price-feeds/core/use-real-time-data/pull-integration/something

@alexcambose
Copy link
Contributor Author

main issues are fixed, basically

["/price-feeds/:path((?!core|pro|push-feeds|use-real-time-data).*?)", "/price-feeds/core/:path*"],

needs to be at the bottom of the redirects structure so nextjs can match others first

@aditya520 aditya520 merged commit 537cc1c into chore(price-feeds)-combine-lazer-push-feeds Oct 21, 2025
4 of 5 checks passed
@aditya520 aditya520 deleted the fix/redirects branch October 21, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants