fixes #8133: migrate to setuptools_scm 6.x by RonnyPfannschmidt · Pull Request #8134 · pytest-dev/pytest

RonnyPfannschmidt · 2020-12-13T10:11:29Z

and use SETUPTOOLS_SCM_PRETEND_VERSION_FOR_PYTEST

RonnyPfannschmidt · 2020-12-13T10:14:11Z

@bluetech i believe the missing install in the deploy command created the problem
do you by chance have around a link to the build job else i'll search for more details sometime in the afternoon

bluetech

Thanks @RonnyPfannschmidt. I didn't test SETUPTOOLS_SCM_PRETEND_VERSION_FOR_PYTEST on CI, only locally. I'll test this when I get a chance.

pyproject.toml

bluetech · 2020-12-13T10:15:40Z

tox.ini

-# TODO: When setuptools-scm 5.0.0 is released, use SETUPTOOLS_SCM_PRETEND_VERSION_FOR_PYTEST
-# and remove the next line.
+passenv = SETUPTOOLS_SCM_PRETEND_VERSION_FOR_PYTEST
 install_command=python -m pip --use-deprecated=legacy-resolver install {opts} {packages}


The fix should enable the removal of the --use-deprecated=legacy-resolver here

bluetech · 2020-12-13T10:18:36Z

Basically the test is SETUPTOOLS_SCM_PRETEND_VERSION_FOR_PYTEST=10.20.30 tox -e regen with a new pip and seeing that:

The regendoc install doesn't fail
The correct version appears in the doc

RonnyPfannschmidt · 2020-12-13T10:23:50Z

@bluetech thanks, i figured the issue - basically tox makes a sdist where the version pretending is not passed, which in turn confuses the rest

im now setting out to configure it correctly

RonnyPfannschmidt · 2020-12-13T10:41:03Z

@bluetech i found a bug in the setuptools_scm pyproject integration, bugfix upcoming

RonnyPfannschmidt · 2020-12-14T12:04:33Z

@gaborbernat is there potentially anything missing for tox to conisder it - even wit the bugfix i see the _FOR_PYTEST version being ignored while the normal one works

RonnyPfannschmidt · 2020-12-14T12:09:56Z

@gaborbernat - nm, after updating a externalsetuptools_scm twice it actually worked, im not sure how that came to be but i suspect i poisoned my user-site, sorry for the noise

nicoddemus

Should we backport this to 6.2.x?

RonnyPfannschmidt · 2020-12-20T15:59:55Z

@bluetech please crosscheck if it works for you as well (to avoid a works on my box)

RonnyPfannschmidt · 2020-12-20T16:00:33Z

@nicoddemus good idea

bluetech · 2020-12-20T21:35:15Z

@RonnyPfannschmidt I checked out this branch and tried the following:

SETUPTOOLS_SCM_PRETEND_VERSION_FOR_PYTEST=10.20.30 tox -e regen

tox does say:

.package recreate: /home/ran/src/pytest/.tox/.package
.package installdeps: setuptools>=42.0, setuptools-scm[toml]>=5.0.1, wheel

but...

regen inst-nodeps: /home/ran/src/pytest/.tox/.tmp/package/1/pytest-6.3.0.dev38+g2753279b1.tar.gz

that is, the specified version doesn't take.

Strangely, even though SETUPTOOLS_SCM_PRETEND_VERSION (without the FOR_PYTEST) is no longer allowed in passenv, that one does work.

I tried to completely rm my .tox directory and verified I the this branch checked out, still happens. Though I might still be missing something.

RonnyPfannschmidt · 2020-12-20T21:51:59Z

Also update SETUPTOOLS_SCM in the surrounding env

bluetech · 2020-12-20T21:54:17Z

What do you mean by surrounding env?

RonnyPfannschmidt · 2020-12-22T20:30:25Z

@bluetech i appologize - the issue is observable for mae again as well

@gaborbernat - is there a easy way to debug what tox is doing here?

for some reason SETUPTOOLS_SCM_PRETEND_VERSION wont make it to the creation of the dist and i have no idea what exactly is wrong

gaborbernat · 2020-12-22T21:33:00Z

Did you passed in at passenv, and just call it with -vvv to see the stdout of the build.

this issues is less likely to hit due to the recent regendoc release which includes a wheel * migrate to setuptools_scm 6.3.2 * use SETUPTOOLS_SCM_PRETEND_VERSION_FOR_PYTEST

RonnyPfannschmidt · 2021-10-02T18:23:35Z

i upgraded this to the most recent setuptools_scm which includes a bugfix
additionally i added extra details to the commit message

RonnyPfannschmidt · 2021-10-02T18:27:29Z

won't need a backport anymore

bluetech

I don't remember all of the details, but the changes LGTM.

RonnyPfannschmidt · 2021-10-02T20:06:42Z

@bluetech there was a combination issue between regendoc and pytest setuptools_scm pretend_version

a pretend version at install time for regendoc would set it up wrong,
and the just for pytest pretend version had a bug that was only just fixed in the latest setuptools_scm version

RonnyPfannschmidt force-pushed the setuptools_scm_5 branch from 28afba6 to a3ca851 Compare December 13, 2020 10:13

bluetech reviewed Dec 13, 2020

View reviewed changes

RonnyPfannschmidt mentioned this pull request Dec 13, 2020

distribution name is not passed from pyproject.toml support pypa/setuptools-scm#507

Closed

RonnyPfannschmidt force-pushed the setuptools_scm_5 branch 2 times, most recently from 6c9a995 to 2753279 Compare December 20, 2020 15:47

RonnyPfannschmidt marked this pull request as ready for review December 20, 2020 15:47

nicoddemus approved these changes Dec 20, 2020

View reviewed changes

RonnyPfannschmidt added the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label Dec 20, 2020

RonnyPfannschmidt force-pushed the setuptools_scm_5 branch from 7a90e6e to 2753279 Compare December 22, 2020 20:20

Base automatically changed from master to main March 9, 2021 20:40

RonnyPfannschmidt force-pushed the setuptools_scm_5 branch from 2753279 to 888ffba Compare May 24, 2021 19:22

fixes pytest-dev#8133: mitigate regendoc issues wrt PRETEND_VERSION

0892c77

this issues is less likely to hit due to the recent regendoc release which includes a wheel * migrate to setuptools_scm 6.3.2 * use SETUPTOOLS_SCM_PRETEND_VERSION_FOR_PYTEST

RonnyPfannschmidt force-pushed the setuptools_scm_5 branch from 888ffba to 0892c77 Compare October 2, 2021 18:22

RonnyPfannschmidt requested review from bluetech and nicoddemus October 2, 2021 18:22

RonnyPfannschmidt removed the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label Oct 2, 2021

bluetech approved these changes Oct 2, 2021

View reviewed changes

RonnyPfannschmidt changed the title ~~fixes #8133: migrate to setuptools_scm 5.x~~ fixes #8133: migrate to setuptools_scm 6.x Oct 3, 2021

RonnyPfannschmidt merged commit 35d8c13 into pytest-dev:main Oct 3, 2021

RonnyPfannschmidt deleted the setuptools_scm_5 branch October 3, 2021 18:46

nicoddemus mentioned this pull request Nov 11, 2025

Release 9.0.1 #13928

Closed

Uh oh!

Conversation

RonnyPfannschmidt commented Dec 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RonnyPfannschmidt commented Dec 13, 2020

Uh oh!

bluetech left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bluetech Dec 13, 2020

Choose a reason for hiding this comment

Uh oh!

bluetech commented Dec 13, 2020

Uh oh!

RonnyPfannschmidt commented Dec 13, 2020

Uh oh!

RonnyPfannschmidt commented Dec 13, 2020

Uh oh!

RonnyPfannschmidt commented Dec 14, 2020

Uh oh!

RonnyPfannschmidt commented Dec 14, 2020

Uh oh!

nicoddemus left a comment

Choose a reason for hiding this comment

Uh oh!

RonnyPfannschmidt commented Dec 20, 2020

Uh oh!

RonnyPfannschmidt commented Dec 20, 2020

Uh oh!

bluetech commented Dec 20, 2020

Uh oh!

RonnyPfannschmidt commented Dec 20, 2020

Uh oh!

bluetech commented Dec 20, 2020

Uh oh!

RonnyPfannschmidt commented Dec 22, 2020

Uh oh!

gaborbernat commented Dec 22, 2020

Uh oh!

RonnyPfannschmidt commented Oct 2, 2021

Uh oh!

RonnyPfannschmidt commented Oct 2, 2021

Uh oh!

bluetech left a comment

Choose a reason for hiding this comment

Uh oh!

RonnyPfannschmidt commented Oct 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

RonnyPfannschmidt commented Dec 13, 2020 •

edited

Loading