Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete "importorskip('unittest.mock')" calls #5608

Merged
merged 2 commits into from
Jul 16, 2019

Conversation

nicoddemus
Copy link
Member

No longer make sense given that unittest.mock is part of the stdlib for all Python versions we support now.

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #5608 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5608      +/-   ##
==========================================
+ Coverage   96.11%   96.12%   +0.01%     
==========================================
  Files         117      117              
  Lines       25775    25770       -5     
  Branches     2495     2495              
==========================================
- Hits        24773    24771       -2     
+ Misses        697      695       -2     
+ Partials      305      304       -1
Impacted Files Coverage Δ
testing/python/integration.py 94.07% <100%> (+0.5%) ⬆️
src/_pytest/pastebin.py 91.22% <0%> (+3.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54e08b7...65c2301. Read the comment docs.

testing/python/integration.py Show resolved Hide resolved
@nicoddemus nicoddemus merged commit 15e235c into pytest-dev:master Jul 16, 2019
@nicoddemus nicoddemus deleted the remove-unused-importorskip branch July 16, 2019 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants