Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message when passing non-string ids to pytest.mark.parametrize #1861

Merged
merged 1 commit into from
Aug 24, 2016
Merged

Improve error message when passing non-string ids to pytest.mark.parametrize #1861

merged 1 commit into from
Aug 24, 2016

Conversation

nicoddemus
Copy link
Member

Fix #1857

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 93.035% when pulling 21a23f5 on nicoddemus:ids-invalid-type-msg into ea0feba on pytest-dev:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 93.035% when pulling 972a5fb on nicoddemus:ids-invalid-type-msg into ea0feba on pytest-dev:master.

@The-Compiler The-Compiler merged commit 3345ac9 into pytest-dev:master Aug 24, 2016
@The-Compiler
Copy link
Member

I agree fixing the error instead of making this valid again is the way to go here - thanks!

@nicoddemus nicoddemus deleted the ids-invalid-type-msg branch August 24, 2016 10:35
@philpep philpep mentioned this pull request Sep 2, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicoddemus @coveralls @The-Compiler