Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #138 (targeted to features branch) #1486

Merged
merged 4 commits into from
Apr 3, 2016

Conversation

roolebo
Copy link
Contributor

@roolebo roolebo commented Mar 27, 2016

The change fixes #138. Exception chain is printed according to PEP-3134.
The tracebacks of each exception in the chain are the same as tracebacks of non-chained exceptions in py.test. The tracebacks are delimited by The above exception was the direct cause of the following exception: or During handling of the above exception, another exception occurred: messages, depending on __cause__ or __context__ respectively. If an exception has both __cause__ and __context__, __cause__ takes priority. The messages are yellow-colored as it looks better than cyan delimiters:
yellow-exc-sep
cyan-exc-sep

@nicoddemus
Copy link
Member

I'm fine with the PR, but would like a second set of eyes before merging. 😁

@roolebo
Copy link
Contributor Author

roolebo commented Apr 2, 2016

Maybe @RonnyPfannschmidt wants to chime in.

@RonnyPfannschmidt
Copy link
Member

this works right now and i don't want to prevent merging it right now by the idea of future refactorings

well done

@RonnyPfannschmidt RonnyPfannschmidt merged commit 0f7aeaf into pytest-dev:features Apr 3, 2016
@roolebo roolebo deleted the fix-issue-138 branch June 6, 2016 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants