fix: validate marker names in -m expression with --strict-markers - #14127
Merged
RonnyPfannschmidt merged 3 commits intoAug 12, 2026
Merged
Conversation
psf-chronographer
Bot
added
the
bot:chronographer:provided
There was a problem hiding this comment.
Pull request overview
This pull request implements validation of marker names in -m (marker expression) arguments when --strict-markers is enabled, addressing issue #2781. Previously, --strict-markers only validated markers used in test decorations (e.g., @pytest.mark.foo), but not markers referenced in command-line -m expressions.
Changes:
- Added tracking of identifier names during expression parsing to capture marker names used in expressions
- Implemented validation of marker names in
-mexpressions against registered markers when strict mode is enabled - Added comprehensive test coverage for the new validation behavior
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/_pytest/mark/expression.py | Modified Scanner, expression parser, and Expression class to track and expose identifier names used in expressions |
| src/_pytest/mark/init.py | Added _validate_marker_names() function to validate markers in expressions when strict_markers is enabled |
| testing/test_mark_expression.py | Added unit tests for the new Expression.idents() method |
| testing/test_mark.py | Added integration test verifying that unregistered markers in -m expressions trigger errors with --strict-markers |
| changelog/2781.feature.rst | Documented the new feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+232
to
+237
| pytester.makeini( | ||
| """ | ||
| [pytest] | ||
| markers = registered: a registered marker | ||
| """ | ||
| ) |
There was a problem hiding this comment.
The makeini call here is redundant because it's immediately overwritten by another makeini call on lines 239-245 when option_name is "strict_markers" or "strict". This first ini file is never used. Consider removing these lines or restructuring the test to avoid creating the ini file twice.
RonnyPfannschmidt
force-pushed
the
fix-2781-strict-markers-m-expression
branch
from
January 18, 2026 11:23
ec4ad16 to
20e1063
Compare
bluetech
approved these changes
Jan 18, 2026
bluetech
left a comment
bluetech
left a comment
Member
There was a problem hiding this comment.
I debated with myself whether this is a good feature. It can help with bad typos, but maybe there's a use case for trying non-registered markers? But I couldn't think of any such use cases. So LGTM. Let's see if anyone complains...
Consider also mentioning this briefly in the strict_markers documentation.
RonnyPfannschmidt
force-pushed
the
fix-2781-strict-markers-m-expression
branch
2 times, most recently
from
January 19, 2026 10:17
56688fb to
2192ac2
Compare
nicoddemus
approved these changes
Jan 21, 2026
RonnyPfannschmidt
force-pushed
the
fix-2781-strict-markers-m-expression
branch
from
July 21, 2026 08:32
9964bfb to
c1a9d4e
Compare
RonnyPfannschmidt
force-pushed
the
fix-2781-strict-markers-m-expression
branch
from
July 31, 2026 12:58
d65846e to
c8e1948
Compare
Extract marker line parsing into a single _iter_registered_markers() method on Config class, replacing duplicate parsing logic in three locations: - MarkGenerator._markers cache population - _validate_marker_names() for strict marker checking - pytest_cmdline_main() for --markers display Introduces RegisteredMarker NamedTuple with name, signature, and description fields for cleaner API. Co-authored-by: Cursor AI <ai@cursor.sh> Co-authored-by: Anthropic Claude Opus 4.5 <claude@anthropic.com>
Closes pytest-dev#2781 Co-authored-by: Cursor AI <ai@cursor.sh> Co-authored-by: Anthropic Claude Opus 4.5 <claude@anthropic.com>
RonnyPfannschmidt
force-pushed
the
fix-2781-strict-markers-m-expression
branch
from
August 9, 2026 13:51
c8e1948 to
a8cc3f1
Compare
_validate_marker_names re-implemented the "markers" ini parsing inline, duplicating the split logic and its comment verbatim from Config._iter_registered_markers. Use the helper instead, matching the other two call sites in mark/__init__.py and mark/structures.py. This also exercises FakeConfig._iter_registered_markers in the tests, which was previously dead code and the sole patch-coverage miss. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2781
When
--strict-markersis enabled, marker names used in-mexpressions are now validated against registered markers.