Remove pytest 8 deprecations #11757
Remove pytest 8 deprecations #11757
Conversation
bluetech
force-pushed
the
rm-removed-in-8
branch
2 times, most recently
from
174a838
to
175ea47
Compare
src/_pytest/hookspec.py
Outdated
| equivalent of the ``path`` parameter. | ||
|
|
||
| .. versionchanged:: 8.0.0 | ||
| The ``path`` parameter has been deprecated. |
There was a problem hiding this comment.
Actually it was removed, not deprecated.
There was a problem hiding this comment.
Was it though? It worked in 8.0 but does not work in 8.1 🤷
There was a problem hiding this comment.
as per deprecation policy, the major release tirggers errors, the next minor version removes the code
the key issue here that we missed a case where warnings don't error
There was a problem hiding this comment.
@RonnyPfannschmidt I get it. What is confusing to me is why the docs says that it was removed in 8.0 rather than that it was removed in 8.1:
From a user's point of view it would be ideal to see "deprecated in 8.0, removed in 8.1", otherwise I see that it worked in 8.0 but does not work in 8.1 and I am just confused.
There was a problem hiding this comment.
the bug here is that it should have failed in 8.x, but due to a warning miss-config it did in fact not fail
the deprecation did happen - see #12068
i vaguely recall the deprecation happened later in the 7.x series as to avoid having dozens of separate deprecation events
bluetech
force-pushed
the
rm-removed-in-8
branch
from
175ea47
to
1ba0745
Compare
Per our deprecation policy, the 8.0.0 merely changes deprecation warnings to deprecation errors (which can still be ignored), with the actual removals in 8.1.0. Since main is now for 8.1, this is the time to do it.