Skip to content

Conversation

CarstenGrohmann
Copy link
Contributor

The old implementation limits the usage of SystemdService.is_valid() to .service units. This implementation allows checking all types of unit files with is_valid() (systemd-analyze verify <unitname.suffix>).

@CarstenGrohmann CarstenGrohmann force-pushed the extend_systemd_unit_suffixes branch 3 times, most recently from 20e014e to c708268 Compare October 9, 2023 06:18
@CarstenGrohmann CarstenGrohmann force-pushed the extend_systemd_unit_suffixes branch from c708268 to 1d999a7 Compare October 17, 2023 13:48
The old implementation limits the usage of SystemdService.is_valid() to
".service" units. This implementation allows checking all types of unit
files with is_valid() (systemd-analyze verify <unitname.suffix>).
@philpep philpep force-pushed the extend_systemd_unit_suffixes branch from 1d999a7 to b7d082e Compare November 13, 2023 16:23
@philpep philpep added the bug This issue/PR relates to a bug. label Nov 13, 2023
@philpep philpep merged commit b54a79e into pytest-dev:main Nov 13, 2023
@philpep
Copy link
Contributor

philpep commented Nov 13, 2023

Merged, thanks!

@CarstenGrohmann CarstenGrohmann deleted the extend_systemd_unit_suffixes branch November 14, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants