Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry SSH on ConnectionResetError #708

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

tacerus
Copy link
Contributor

@tacerus tacerus commented Jun 20, 2023

Hello,

I faced the same issue described in #66 (comment), however #71 did not help, as the exception in my case was not a Paramiko SSHException, but a ConnectionResetError.

This patch adds the latter exception to be handled equally.

If a target host temporarily looses connection, for example upon
resetting a test VM as part of a parametrized test run, retry the SSH
connection the same way it is retried upon an SSH exception.

Signed-off-by: Georg Pfuetzenreuter <[email protected]>
@philpep philpep added the bug This issue/PR relates to a bug. label Aug 24, 2023
@philpep philpep merged commit a12badf into pytest-dev:main Aug 24, 2023
5 of 6 checks passed
@philpep
Copy link
Contributor

philpep commented Aug 24, 2023

Merged, thanks!

@tacerus
Copy link
Contributor Author

tacerus commented Aug 24, 2023

Thanks as well! :-)

@tacerus tacerus deleted the ConnectionResetError branch August 24, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants