Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New mocker.mock_module variable points to the underlying mock module being used #72

Merged
merged 1 commit into from
Nov 22, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion CHANGELOG.rst
Original file line number Diff line number Diff line change
@@ -1,9 +1,18 @@
1.5.0
-----

* New ``mocker.mock_module`` variable points to the underlying mock module being used
(``unittest.mock`` or ``mock``).
Thanks `@blueyed`_ for the request (`#71`_).

.. _#71: https://github.com/pytest-dev/pytest-mock/pull/71

1.4.0
-----

* New configuration variable, ``mock_use_standalone_module`` (defaults to ``False``). This forces
the plugin to import ``mock`` instead of ``unittest.mock`` on Python 3. This is useful to import
and use a newer version than the one available in the Python distribution.
a newer version than the one available in the Python distribution.

* Previously the plugin would first try to import ``mock`` and fallback to ``unittest.mock``
in case of an ``ImportError``, but this behavior has been removed because it could hide
Expand Down
16 changes: 8 additions & 8 deletions pytest_mock.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
import sys

import pytest

from _pytest_mock_version import version

__version__ = version


Expand Down Expand Up @@ -34,7 +34,7 @@ class MockFixture(object):
def __init__(self, config):
self._patches = [] # list of mock._patch objects
self._mocks = [] # list of MagicMock objects
self._mock_module = mock_module = _get_mock_module(config)
self.mock_module = mock_module = _get_mock_module(config)
self.patch = self._Patcher(self._patches, self._mocks, mock_module)
# aliases for convenience
self.Mock = mock_module.Mock
Expand Down Expand Up @@ -104,7 +104,7 @@ def stub(self, name=None):
:rtype: mock.MagicMock
:return: Stub object.
"""
return self._mock_module.MagicMock(spec=lambda *args, **kwargs: None, name=name)
return self.mock_module.MagicMock(spec=lambda *args, **kwargs: None, name=name)

class _Patcher(object):
"""
Expand All @@ -115,7 +115,7 @@ class _Patcher(object):
def __init__(self, patches, mocks, mock_module):
self._patches = patches
self._mocks = mocks
self._mock_module = mock_module
self.mock_module = mock_module

def _start_patch(self, mock_func, *args, **kwargs):
"""Patches something by calling the given function from the mock
Expand All @@ -130,20 +130,20 @@ def _start_patch(self, mock_func, *args, **kwargs):

def object(self, *args, **kwargs):
"""API to mock.patch.object"""
return self._start_patch(self._mock_module.patch.object, *args, **kwargs)
return self._start_patch(self.mock_module.patch.object, *args, **kwargs)

def multiple(self, *args, **kwargs):
"""API to mock.patch.multiple"""
return self._start_patch(self._mock_module.patch.multiple, *args,
return self._start_patch(self.mock_module.patch.multiple, *args,
**kwargs)

def dict(self, *args, **kwargs):
"""API to mock.patch.dict"""
return self._start_patch(self._mock_module.patch.dict, *args, **kwargs)
return self._start_patch(self.mock_module.patch.dict, *args, **kwargs)

def __call__(self, *args, **kwargs):
"""API to mock.patch"""
return self._start_patch(self._mock_module.patch, *args, **kwargs)
return self._start_patch(self.mock_module.patch, *args, **kwargs)


@pytest.yield_fixture
Expand Down