Wrap assert methods of mock module to clean up traceback

[Chronial]

Fixes #26

[Chronial]

This is proving to be more difficult than expected ^^.

[Chronial]

There we go, working now.

[nicoddemus]

I think for completeness we should also implement pytest_unconfigure to undo all the patches.

[Chronial]

Yes, I had that – but then the tests break, because the tests actually run a second pytest in the same process. That pytest will also call unconfigure, and the patching will be gone for all following tests.

But see line 209 – that does exactly what you're asking for.

[nicoddemus]

I'm a little uneasy of doing this wrapping automatically for everyone which uses the plugin... there are a tons of test suites, some of them doing already some deep dark magic on their on, who knows what this might break? I agree with you it is unlikely, but I think we should add an option to disable this. How about an ini option:

[pytest]
mock_traceback_monkeypatch = false

The default would be true, but users can disable it at will at least. What do you think?

[Chronial]

Yes, I agree – it's quite agressive and I felt the pain of this while writing it. But as I can't see any other way to make sure that the patching is there when somebody uses mock in a test, I think a config option would probably be a good way to handle problems. I'll add one.

[nicoddemus]

Thanks! 😄

[nicoddemus]

But see line 209 – that does exactly what you're asking for.

Oops, missed that, thanks!

[nicoddemus]

Hey thanks a lot for the PR! The code looks great!

Other than my other comments, the only thing left to do is mention this new feature in the README.

[Chronial]

done 😄

[nicoddemus]

Thanks a lot! I will merge this tonight and make a new release. 😄

[The-Compiler]

👍

[nicoddemus]

Released 0.10.0 😄

Thanks again!