Initial backend for Next Gen #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks @BeyondEvil ! I'll take a look as soon as I can |
gnikonorov
reviewed
Dec 17, 2020
gnikonorov
reviewed
Dec 18, 2020
There was a problem hiding this comment.
Other than these comments, LGTM! Thank you again @BeyondEvil !
| @@ -0,0 +1,66 @@ | |||
| import json | |||
| from typing import Any | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| data = json.dumps(data) | ||
|
|
||
| with self._data_file.open("w", buffering=1, encoding="UTF-8") as f: | ||
| f.write("const jsonData = ") |
There was a problem hiding this comment.
can we combine these f.write calls on an f string line f"const jsonData = {data}\n"?
| f.write("\n") | ||
|
|
||
| @pytest.hookimpl(trylast=True) | ||
| def pytest_sessionstart(self, session): |
There was a problem hiding this comment.
Wouldn't all the self._write calls overwrite self._data_file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial backend, implemented alongside the "legacy" report.
It will create a JSON file with the title, environment (from metadata) and all tests.
Any calculations, summary of passed/failed, durations etc. will be left to the frontend.
extrasandhooksare not implemented yet.I know why the tests are failing, will fix tomorrow.