Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to getfixturedefs change in pytest 8.1 #213

Merged
merged 6 commits into from
Jan 21, 2024

Conversation

bluetech
Copy link
Member

@bluetech bluetech commented Jan 8, 2024

The signature of this (private) function will change in the upcoming pytest 8.1 release:
pytest-dev/pytest#11785

I verified that all tests pass when run against pytest main.

The signature of this (private) function will change in the upcoming
pytest 8.1 release:
pytest-dev/pytest#11785

I verified that all tests pass when run against pytest main.
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (03eeebf) 97.76% compared to head (450d857) 97.76%.

Files Patch % Lines
pytest_factoryboy/compat.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #213   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files          14       14           
  Lines         849      851    +2     
  Branches      140      134    -6     
=======================================
+ Hits          830      832    +2     
  Misses         10       10           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@youtux youtux merged commit 9790d91 into pytest-dev:master Jan 21, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants