Fix support for Django 3.2 #857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
commented
Aug 14, 2020
| except ImportError: | ||
|
|
||
|
|
||
| def _get_setup_and_teardown_databases(): |
Contributor
Author
There was a problem hiding this comment.
Refactor code such that we can use return to avoid deeply nested try-except blocks.
bluetech
approved these changes
Aug 15, 2020
Contributor
Author
|
Not sure how the tests broke and I don't really understand them... |
Member
|
The tests should be fixed by #861, which is unrelated, so we can merge this. Thanks! |
This was referenced Aug 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.