Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pytest-cov[toml] akin to upstream coverage[toml] #553

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

stdedos
Copy link
Contributor

@stdedos stdedos commented Sep 16, 2022

nedbat/coveragepy#664 (+ later fixes)

Signed-off-by: Stavros Ntentos [email protected]

setup.py Outdated Show resolved Hide resolved
@ofek
Copy link

ofek commented Oct 9, 2022

Related #508

@stdedos
Copy link
Contributor Author

stdedos commented Oct 18, 2022

@ionelmc all good now? 😕

@ionelmc ionelmc merged commit f7bdfcf into pytest-dev:master Oct 18, 2022
@ionelmc
Copy link
Member

ionelmc commented Oct 18, 2022

Yes, yes.

@ofek
Copy link

ofek commented Oct 20, 2022

Wait, what's the point of this? We already do that:

pytest-cov/setup.py

Lines 132 to 135 in f7bdfcf

install_requires=[
'pytest>=4.6',
'coverage[toml]>=5.2.1'
],

@ofek ofek mentioned this pull request Oct 20, 2022
@stdedos
Copy link
Contributor Author

stdedos commented Oct 20, 2022

When I tried to move .coveragerc to pyproject.toml, I was unable to read the configuration.

I assumed that this was a necessary step (and I was going to test if this fixed the issue after a new pypi release).

@ofek
Copy link

ofek commented Oct 20, 2022

Without #508 you need --cov-config=pyproject.toml

@stdedos
Copy link
Contributor Author

stdedos commented Oct 20, 2022

Without #508 you need --cov-config=pyproject.toml

Oh well 🤦

Good to know; I'll try to check this on my new project sometime.

@ionelmc
Copy link
Member

ionelmc commented Oct 20, 2022

Facepalm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants