Fix race condition in test #214
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmbowman
force-pushed
the
fix_test_race_condition
branch
from
eb98eb3 to
65428a5
Compare
Member
|
Rebased as 115155d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test has been intermittently failing recently both for PRs and master. The original process sometimes manages to terminate the spawned process right after it calls
event.set(), so it never gets totime.sleep(5)yielding less than the expected 100% coverage. I think this 0.5 second wait should be enough for the spawned process to always hit thewaitstatement without slowing the test down perceptibly. I tried 0.1 seconds first, but the pypy tests still failed in Travis with that.