Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add how-to guide for testing with uvloop #588

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

seifertm
Copy link
Contributor

This PR adds a how-to guide for testing with uvloop.

The guide is being added as a follow up to the discussion #587.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (5731bd2) 93.95% compared to head (07ce100) 93.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #588   +/-   ##
=======================================
  Coverage   93.95%   93.95%           
=======================================
  Files           2        2           
  Lines         281      281           
  Branches       55       55           
=======================================
  Hits          264      264           
  Misses         11       11           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seifertm
Copy link
Contributor Author

Setting the loop policy inside a fixture may cause issues ( see #591). Therefore, I adjusted the how-to guide to set the policy directly in conftest.py rather than in a pytest fixture.

@seifertm seifertm merged commit 186172c into pytest-dev:main Aug 1, 2023
8 checks passed
@seifertm seifertm deleted the how-to-test-with-uvloop branch October 23, 2023 06:16
@seifertm seifertm restored the how-to-test-with-uvloop branch October 23, 2023 08:17
@seifertm seifertm deleted the how-to-test-with-uvloop branch October 23, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants