All tests return "success" when they are successful #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orts success rather than "xfailed" when the test succeeded. Signed-off-by: Michael Seifert <[email protected]>
…k.xfail in auto mode. Signed-off-by: Michael Seifert <[email protected]>
…rts success rather than "skipped" when the test succeeds. Signed-off-by: Michael Seifert <[email protected]>
…p in auto mode. Signed-off-by: Michael Seifert <[email protected]>
The test simply asserts that the event loop can be closed inside a test. Given that the event_loop fixture returns a regular event loop, this test case simply tests standard-library behavior and is not needed for pytest-asyncio. Signed-off-by: Michael Seifert <[email protected]>
seifertm
force-pushed
the
no-non-successful-tests
branch
from
6879238
to
9eae85a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there have been some tests that try to assert compatibility with pytest.mark.xfail or pytest.skip. Those tests reported "xfailed" or "skipped" in the test suite.
This creates extra work for downstream packagers of pytest-asyncio if they want to run the unit test suite as part of the installation process.
This MR changes the tests to return "success" when they are successful. More specifically, the tests were changed to run inside Pytester.
The test suite was also extended to test the corresponding behaviors in auto mode.
One unnecessary test case was removed.