Skip to content

Add Python 3.12 to the test suite #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrbean-bremen merged 14 commits into from
Dec 22, 2022
Merged

Add Python 3.12 to the test suite #764

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ccd41d2
Add Python 3.12 to the test suite
browniebroke Dec 21, 2022
3748e6a
Fix failures under Python 3.12
browniebroke Dec 21, 2022
39a80cf
Mark Python 3.12 as experimental
browniebroke Dec 21, 2022
d0cfd0e
Add is_junction method to DirEntry class on Python 3.12
browniebroke Dec 21, 2022
887d6b0
Implement stub functions for os.path.isjunction()
browniebroke Dec 21, 2022
164879d
Always return false in stub junction functions
browniebroke Dec 22, 2022
ebd31f2
Skip extra deps tests for experimental jobs
browniebroke Dec 22, 2022
2a60d68
Update changelog to mention support for Python 3.12
browniebroke Dec 22, 2022
dcdb458
Make junction APIs conditional on Python 3.12
browniebroke Dec 22, 2022
be93897
Simplify test suite workflow by removing experimental flag
browniebroke Dec 22, 2022
a0d1f72
Enable performance tests on Python 3.12
browniebroke Dec 22, 2022
cb03c5c
Fix condition
browniebroke Dec 22, 2022
311c982
Fix grammar in docstrings
browniebroke Dec 22, 2022
f1b954b
Fix condition in workflow
browniebroke Dec 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .github/workflows/testsuite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,26 @@ on:
jobs:
tests:
runs-on: ${{ matrix.os }}
continue-on-error: ${{ matrix.experimental }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macOS-latest, windows-latest]
python-version: [3.7, 3.8, 3.9, "3.10", "3.11"]
experimental: [false]
include:
- python-version: "pypy-3.7"
os: ubuntu-latest
- os: ubuntu-latest
python-version: "pypy-3.7"
experimental: false
- os: ubuntu-latest
python-version: "3.12-dev"
experimental: true
- os: macOS-latest
python-version: "3.12-dev"
experimental: true
- os: windows-latest
python-version: "3.12-dev"
experimental: true
Copy link
Member

@mrbean-bremen mrbean-bremen Dec 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably just disable the tests with extra requirements for 3.12 (by adding a version check to the respective steps). It is common that larger packages do not support a new Python in early development stages. We can remove the check later.


steps:
- uses: actions/checkout@v2
Expand Down
5 changes: 5 additions & 0 deletions pyfakefs/fake_pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,10 @@
import fnmatch
import functools
import inspect
import ntpath
import os
import pathlib
import posixpath
import re
import sys
from pathlib import PurePath
Expand Down Expand Up @@ -383,6 +385,7 @@ class _FakeWindowsFlavour(_FakeFlavour):
| {"COM%d" % i for i in range(1, 10)}
| {"LPT%d" % i for i in range(1, 10)}
)
pathmod = ntpath
Copy link
Contributor Author

@browniebroke browniebroke Dec 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class attribute was present but seemingly unused before python/cpython#95450


def is_reserved(self, parts):
"""Return True if the path is considered reserved under Windows."""
Expand Down Expand Up @@ -459,6 +462,8 @@ class _FakePosixFlavour(_FakeFlavour):
independent of FakeFilesystem properties.
"""

pathmod = posixpath

def is_reserved(self, parts):
return False

Expand Down
1 change: 1 addition & 0 deletions pyfakefs/tests/fake_pathlib_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,6 +632,7 @@ def test_symlink_to(self):
self.assertTrue(path.is_symlink())

@unittest.skipIf(sys.version_info < (3, 8), "link_to new in Python 3.8")
@unittest.skipIf(sys.version_info >= (3, 12), "link_to removed in Python 3.12")
Copy link
Contributor Author

@browniebroke browniebroke Dec 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/python/cpython/blob/0397f040e239c82848f51dedef9af7b9bd99ef55/Lib/pathlib.py#L1222-L1225

Copy link
Member

@mrbean-bremen mrbean-bremen Dec 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this had been deprecated before (actually renamed to hardlink_to).

def test_link_to(self):
self.skip_if_symlink_not_supported()
file_name = self.make_path("foo", "bar.txt")
Expand Down