Use fissix in order to support newer python versions

[dosas]

#16

[jayvdb]

Looks like there are two expected strings which need to be adjusted to match what fissix produces.

[dosas]

Looks like this is the same problem as described here #15

[cclauss]

@dosas Would you be willing to add the changes from #21 and then I can close #21? I think it would be easier for maintainers to review and accept the changes in this PR if it included working continuous integration testing.

[dosas]

@cclauss Done.

[cclauss]

Cool. Thanks. Let’s see what happens when a maintainer gives the jobs permission to run.

[dosas]

It will probably fail due to #15 ;)

[cclauss]

Please rebase.

[jayvdb]

ping @dosas

[dosas]

pong

[schollii]

Looks like this is still WIP? Also there are conflicts to resolve. Let me know when this is ready for review, I look forward to merging this.

[cclauss]

@schollii Your review, please.

[schollii]

I'm not seeing the tox test suite results proving that everything works fine after the changes, are they somewhere else? Sorry it's been a while since I looked at pytest cicd here.

Update : I can see "Checks waiting for approval" and a button "Approve and run", that's probably what will run tox but can someone confirm that's what I have to do, I don't want to approve PR until I see this.

[nicoddemus]

It needed approval to run the test suite (GH does that for first contributors to avoid crypto-spam).

Just gave approval, CI is running.

[schollii]

Changes look good and all tests pass, so good to go!

Thank you @ich and @dosas for doing this.

[cclauss]

Next steps?

[nicoddemus]

I guess all that is left is for @schollii to merge it?