Skip to content

Use mambaforge for CI. #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobiasraabe merged 2 commits into from
Jan 23, 2023
Merged

Use mambaforge for CI. #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a807c01
Use mambaforge for CI.
tobiasraabe Jan 23, 2023
6c4ffef
Fix tests.
tobiasraabe Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
auto-update-conda: false
python-version: ${{ matrix.python-version }}
channels: conda-forge,nodefaults
mamba-version: "*"
miniforge-variant: Mambaforge

- name: Install core dependencies.
shell: bash -l {0}
Expand Down
5 changes: 3 additions & 2 deletions tests/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,17 @@ def test_interplay_between_debugging_and_parallel(tmp_path, pdb, n_workers, expe
("parallel_backend", "unknown_backend", ExitCode.CONFIGURATION_FAILED),
]
+ [
("parallel_backend", parallel_backend.value, ExitCode.OK)
("parallel_backend", parallel_backend, ExitCode.OK)
for parallel_backend in ParallelBackendChoices
],
)
def test_reading_values_from_config_file(
tmp_path, configuration_option, value, exit_code
):
config_value = value.value if isinstance(value, ParallelBackendChoices) else value
config = f"""
[tool.pytask.ini_options]
{configuration_option} = {value!r}
{configuration_option} = {config_value!r}
"""
tmp_path.joinpath("pyproject.toml").write_text(textwrap.dedent(config))

Expand Down
13 changes: 9 additions & 4 deletions tests/test_execute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
from pytask import main
from pytask import Task
from pytask_parallel.backends import PARALLEL_BACKENDS
from pytask_parallel.backends import ParallelBackendChoices
from pytask_parallel.execute import _Sleeper
from pytask_parallel.execute import DefaultBackendNameSpace
from pytask_parallel.execute import ProcessesNameSpace
Expand Down Expand Up @@ -129,9 +130,9 @@ def myfunc():
session.config["_parallel_executor"] = executor

backend_name_space = {
"processes": ProcessesNameSpace,
"threads": DefaultBackendNameSpace,
"loky": DefaultBackendNameSpace,
ParallelBackendChoices.PROCESSES: ProcessesNameSpace,
ParallelBackendChoices.THREADS: DefaultBackendNameSpace,
ParallelBackendChoices.LOKY: DefaultBackendNameSpace,
}[parallel_backend]

future = backend_name_space.pytask_execute_task(session, task)
Expand Down Expand Up @@ -269,7 +270,11 @@ def task_example(produces):
@pytest.mark.parametrize(
"parallel_backend",
# Capturing warnings is not thread-safe.
[backend for backend in PARALLEL_BACKENDS if backend != "threads"],
[
backend
for backend in PARALLEL_BACKENDS
if backend != ParallelBackendChoices.THREADS
],
)
def test_collect_warnings_from_parallelized_tasks(runner, tmp_path, parallel_backend):
source = """
Expand Down