-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing tp_as_mapping, tp_as_sequence and tp_as_number functions #1197
Labels
Comments
I added #1198 as an example for such a change. |
For example |
Our list object is very similar to CPython's, so that sounds like a good place to start even if there are small things that might have to be adjusted. |
sizeoftank
pushed a commit
to sizeoftank/pyston_v1
that referenced
this issue
Jul 9, 2016
sizeoftank
pushed a commit
to sizeoftank/pyston_v1
that referenced
this issue
Jul 12, 2016
sizeoftank
pushed a commit
to sizeoftank/pyston_v1
that referenced
this issue
Jul 12, 2016
sizeoftank
pushed a commit
to sizeoftank/pyston_v1
that referenced
this issue
Jul 13, 2016
sizeoftank
pushed a commit
to sizeoftank/pyston_v1
that referenced
this issue
Jul 18, 2016
undingen
added a commit
that referenced
this issue
Jul 18, 2016
…issue1197 Add sq_slots & mp_slots to instance (issue #1197)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some of our builtin types don't overwrite all of this functions.
This means the perf will be slightly worse because we will call into the slot wrapper which will than do an attribute lookup instead of just calling the function pointer.
One example is our
list
type which does not initialize thetp_as_mapping
function pointers.They are therefore initialized to
slot_sq_length
, etc.. while we should overwrite them with custom implementations likelist_length
.The text was updated successfully, but these errors were encountered: