Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to list filename without directory slash in .vtt file #65

Closed
philipgoyal opened this issue Apr 17, 2023 · 7 comments
Closed

Unable to list filename without directory slash in .vtt file #65

philipgoyal opened this issue Apr 17, 2023 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@philipgoyal
Copy link

I would like .vtt entries to look like this:

00:00:00.000 --> 00:00:05.000
video.png#xywh=0,0,384,216

i.e. the .png file is referred to directly, not prepended with anything.

But if I choose generator.base = "", then the filename is prepended with generator.output.

And if I choose generator.base = " ", then the filename appears as:

\video.png#xywh=0,0,384,216

Could you fix this?

Many thanks!

@ArtyomVancyan
Copy link
Member

Hi @philipgoyal, thanks for the report.

It is because the run directory depends on the path calculation. It uses paths relative to the running directory. So you can just run the script or CLI from the directory where the video is.

Thanks, I hope this fixes your issue.

@philipgoyal
Copy link
Author

philipgoyal commented Apr 17, 2023 via email

@ArtyomVancyan
Copy link
Member

Sorry @philipgoyal, for the misunderstanding. It is my fault for not having a proper issue template requiring the things you've tried, your expectations, and the actual result. Yes, the output value matters in calculating the thumbnail path in the .vtt. It is just the directory path where the generated files should be placed, and the base is the URI prefix as described in the thumbnails -h result, and it overrides the path prefix even if output is set.

If the above information doesn't solve your issue and you still have any questions, please answer these questions as detailed as possible.

  • Are you using the CLI version or the Python package?
  • How do your files' paths relate to each other? (please provide the files tree, including the videos and the script if you use the Python package, otherwise the path where the command is run)
  • Expected result in a few lines.
  • Actual result in a few lines.

Please do not hesitate to ask questions about the non-mentioned cases if there are some. I will wait for you to reply.

@philipgoyal
Copy link
Author

philipgoyal commented Apr 17, 2023 via email

@ArtyomVancyan ArtyomVancyan self-assigned this Apr 18, 2023
@ArtyomVancyan ArtyomVancyan added the bug Something isn't working label Apr 18, 2023
@ArtyomVancyan ArtyomVancyan moved this to In Progress in thumbnails Apr 18, 2023
ArtyomVancyan added a commit to ArtyomVancyan/thumbnails that referenced this issue Apr 18, 2023
ArtyomVancyan added a commit to ArtyomVancyan/thumbnails that referenced this issue Apr 18, 2023
ArtyomVancyan added a commit to ArtyomVancyan/thumbnails that referenced this issue Apr 18, 2023
@ArtyomVancyan
Copy link
Member

Hey @philipgoyal, check out the latest release by pip install --upgrade thumbnails and try to set the base to an empty string. It works for me. Please verify if it works for you as well.

@philipgoyal
Copy link
Author

philipgoyal commented Apr 18, 2023 via email

@github-project-automation github-project-automation bot moved this from In Progress to Done in thumbnails Apr 19, 2023
@philipgoyal
Copy link
Author

I've closed the issue as it has been resolved by the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants