Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an CLI option for forcing the overwrite #55

Closed
ArtyomVancyan opened this issue Feb 11, 2023 · 0 comments
Closed

Add an CLI option for forcing the overwrite #55

ArtyomVancyan opened this issue Feb 11, 2023 · 0 comments
Assignees
@ArtyomVancyan
Labels
enhancement New feature or request

Comments

@ArtyomVancyan
Copy link
Member

ArtyomVancyan commented Feb 11, 2023 •
edited
Loading

There is an option to skip over the already generated files, but there is no opposite option that would force the overwriting.

PR:
@ArtyomVancyan ArtyomVancyan converted this from a draft issue Feb 11, 2023
@ArtyomVancyan ArtyomVancyan self-assigned this Feb 11, 2023
@ArtyomVancyan ArtyomVancyan added the enhancement New feature or request label Feb 11, 2023
@ArtyomVancyan ArtyomVancyan moved this from Todo to In Progress in thumbnails Feb 11, 2023
ArtyomVancyan added a commit to ArtyomVancyan/thumbnails that referenced this issue Feb 11, 2023
@ArtyomVancyan
pysnippetGH-55: Overwrite the existing files by default
050b034
ArtyomVancyan added a commit to ArtyomVancyan/thumbnails that referenced this issue Feb 11, 2023
@ArtyomVancyan
pysnippetGH-55: Replace the filter with list comprehension
f268e26
@ArtyomVancyan ArtyomVancyan mentioned this issue Feb 11, 2023
Merged
ArtyomVancyan added a commit to ArtyomVancyan/thumbnails that referenced this issue Feb 12, 2023
@ArtyomVancyan
pysnippetGH-55: Add unit test for checking overwrite
07ec7dc
ArtyomVancyan added a commit that referenced this issue Feb 12, 2023
@ArtyomVancyan
GH-55: Force overwrite if the skip flag is not set (GH-56)
69c3fed 
* Overwrite the existing files by default
* Replace the `filter` with list comprehension
* Add unit test for checking the overwrite
@github-project-automation github-project-automation bot moved this from In Progress to Done in thumbnails Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtyomVancyan ArtyomVancyan

Labels
enhancement New feature or request
Projects
thumbnails
Status: Done
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

force-option ArtyomVancyan/thumbnails
1 participant
@ArtyomVancyan