Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #755

Merged
merged 1 commit into from
Dec 24, 2023
Merged

Bug fixes #755

merged 1 commit into from
Dec 24, 2023

Conversation

ggarzonie
Copy link
Contributor

Changed code in section 2.8 of notebook. Section 5 of the connected components notebook didn't work, changes in util.py fixed it. I have tested the code using test_network.py. I'm not sure how to assign a reviewer.

Changed code in section 2.8 of notebook. Section 5 of the connected components notebook didn't work, changes in util.py fixed it.
Copy link

codecov bot commented Dec 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b14c9e7) 99.3% compared to head (a2f8b95) 99.3%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #755   +/-   ##
=====================================
  Coverage   99.3%   99.3%           
=====================================
  Files          4       4           
  Lines       1140    1141    +1     
=====================================
+ Hits        1132    1133    +1     
  Misses         8       8           
Files Coverage Δ
spaghetti/util.py 100.0% <100.0%> (ø)

@jGaboardi
Copy link
Member

@ggarzonie Thanks for the PR!

@jGaboardi jGaboardi added the bug label Dec 24, 2023
@jGaboardi jGaboardi merged commit b5b7bdd into pysal:main Dec 24, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants