Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: test against nightlies #188

Merged
merged 6 commits into from
Sep 5, 2023
Merged

CI: test against nightlies #188

merged 6 commits into from
Sep 5, 2023

Conversation

martinfleis
Copy link
Member

Closes #187

@martinfleis
Copy link
Member Author

I gotta admit that some changes in numpy 2.0 are a bit annoying. Like

>>> list(numpy.arange(3, dtype=float))
[np.float64(0.0), np.float64(1.0), np.float64(2.0)]

Which previously returned [0.0, 1.0, 2.0]. Numpy dtypes are propagated much more. It should not have any effect computation-wise, but the __repr__ is different, causing docstring tests to fail and imho unnecessary noise in __repr__. But I guess we'll have to live with it.

@jGaboardi jGaboardi added the CI label Sep 5, 2023
@jGaboardi jGaboardi merged commit f16cb29 into pysal:main Sep 5, 2023
@martinfleis martinfleis deleted the ci branch September 5, 2023 12:52
@jakirkham jakirkham mentioned this pull request May 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jGaboardi jGaboardi jGaboardi approved these changes

Assignees

@martinfleis martinfleis

Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test against the nightly wheel – numpy
2 participants
@martinfleis @jGaboardi