Use camo in development and restrict CSP img-src #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Development should match production as much as possible, so we'll run camo even in development. However we don't know what the domain of the local site is development so we need a small hack to support late binding of the actual hostname (but not port number). This also means that camo is no longer an optional part of a deployment.
dstufft
added a commit
that referenced
this pull request
Mar 6, 2015
Use camo in development and restrict CSP img-src
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To better match a production deployment we're going to run a copy of camo locally and use that even in development. Since all user supplied images go through Camo then, we can also restrict the img-src of the CSP to only use the hosts we expect instead of all hosts.