Skip to content

Conversation

@th3coop
Copy link
Contributor

@th3coop th3coop commented Mar 8, 2024

No description provided.

@woodruffw
Copy link
Member

Thanks @th3coop! I did a quick scan; I'll also stand this up locally in a bit to confirm the render is as expected.

ActiveState organization associated with the project.
* The ActiveState Platform project must be private.
For more information about Trusted Publishing using the ActiveState Platform please
see the [PyPI configuration documentation](https://docs.activestate.com/platform/start/PYPI) and the [ActiveState Platform documentation](https://docs.activestate.com/platform).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: https://docs.activestate.com/platform/start/PYPI currently 404s, but that may be intended.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. They will be up soon.

TODO
For ActiveState, you need to provide the project name on ActiveState's Platform,
the organization that project belongs to, and the username performing
the publish action. Learn more about getting set up on the ActiveState Platform [here](https://docs.activestate.com/platform/start/PYPI).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this URL will start resolving sometime after we enable this feature?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, correct. It should be live soon. We'll get it set up so that it can be viewable before we go live.

=== "ActiveState"

TODO
ActiveState's Platform works as a "zero-config" CI solution to automatically build cross-platform wheels of your PyPI projects. Once you're set up on the Platform and have linked your PyPI project, you're ready to publish. For more information on getting started with ActiveState go [here](https://docs.activestate.com/platform/start/PYPI). To begin:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something we can link to that details the supported platforms/architectures/etc.?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. It's available via the API, but we'll look at putting something together in the linked docs that's easy to reference.

th3coop and others added 6 commits March 8, 2024 12:51
Co-authored-by: Dustin Ingram <[email protected]>
Co-authored-by: Dustin Ingram <[email protected]>
Co-authored-by: Dustin Ingram <[email protected]>
Co-authored-by: Dustin Ingram <[email protected]>
Co-authored-by: Dustin Ingram <[email protected]>
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think we can merge this into the bigger WIP docs branch as-is, even if there are still 404s.

(Looks like the CI needs to be kicked over, but I don't have the permission for that.)

@th3coop
Copy link
Contributor Author

th3coop commented Mar 12, 2024

@woodruffw we have a couple more changes coming. Pete will update. I'd like to squash those Review Edit commits out of the history as well when Pete is done.

@di
Copy link
Member

di commented Mar 12, 2024

(No need to squash out commits, they'll get squashed when we merge!)

@th3coop
Copy link
Contributor Author

th3coop commented Mar 12, 2024

OH right, I knew that! Thanks for the reminder @di.

@th3coop
Copy link
Contributor Author

th3coop commented Mar 12, 2024

@di or @woodruffw, is it possible to see the logs of test.pypi.org? We're having trouble tracking down an issue where test.pypi.org rejects an OIDC token that is accepted by a locally runnning warehouse with the same/similar pending publisher configured.

What's the best way to proceed to debug this?

@rawktron
Copy link
Contributor

@woodruffw we have a couple more changes coming. Pete will update. I'd like to squash those Review Edit commits out of the history as well when Pete is done.

Ok -- I pushed the updates I needed to push for the docs. @woodruffw @di @th3coop

@th3coop
Copy link
Contributor Author

th3coop commented Mar 12, 2024

@di or @woodruffw, is it possible to see the logs of test.pypi.org? We're having trouble tracking down an issue where test.pypi.org rejects an OIDC token that is accepted by a locally runnning warehouse with the same/similar pending publisher configured.

What's the best way to proceed to debug this?

Sorry for the noies @di and @woodruffw! I'm pretty sure we figured it out.

@di di marked this pull request as ready for review March 12, 2024 23:06
@di di requested a review from a team as a code owner March 12, 2024 23:06
@di
Copy link
Member

di commented Mar 12, 2024

Great @th3coop @rawktron -- is this good to go on your end then?

@rawktron
Copy link
Contributor

Great @th3coop @rawktron -- is this good to go on your end then?

@di So on the docs side, fingers crossed yes this should be complete. On the technical side, we're still working through some integration issues to get everything working end to end with test.pypi.org, but that shouldn't (famous last words) alter the instructions here. We also still need to flip those few external pages live as well to get rid of the 404s.

@di
Copy link
Member

di commented Mar 12, 2024

OK, I'll hold off on merging until you confirm you've got everything right technically -- I'm fine with merging this with 404s for now since it won't go live until we merge #15192.

@rawktron
Copy link
Contributor

rawktron commented Mar 20, 2024

OK, I'll hold off on merging until you confirm you've got everything right technically -- I'm fine with merging this with 404s for now since it won't go live until we merge #15192.

@di Alright, everything seems to be working end-to-end technically now, and I pushed one more update to the docs to reflect a few tweaks. So I think we're good to merge into 15192. Thanks for your patience!

@di di merged commit b9b1532 into pypi:more-oidc-docs Mar 20, 2024
di added a commit that referenced this pull request Apr 17, 2024
* docs/user: empty sections for more publishers

Signed-off-by: William Woodruff <[email protected]>

* Fix headings

* Add provider TODOs to using-a-publisher.md

* Move images into provider-specific directories

* Update GitHub screenshots

* Fix asset links

* Update admonition to match

* Remove unnecessary quoting

* Google Trusted Publishing docs (#15195)

* Google Trusted Publishing docs

* Update docs/user/trusted-publishers/security-model.md

Co-authored-by: Facundo Tuesca <[email protected]>

* Update docs/user/trusted-publishers/security-model.md

Co-authored-by: Facundo Tuesca <[email protected]>

* Apply suggestions from code review

Co-authored-by: William Woodruff <[email protected]>

* Apply suggestions from code review

---------

Co-authored-by: Facundo Tuesca <[email protected]>
Co-authored-by: William Woodruff <[email protected]>

* Add Google screenshots

* Fix provider-specific screenshots

* Add GitLab Trusted Publishing docs (#15283)

* Add GitLab Trusted Publishing docs

* Add screenshots to GitLab Trusted Publishing docs

* Fix instructions for GitLab CI with Trusted Publishing

* Add activestate OIDC docs (#15548)

* First draft of ActiveState Trusted Publishing docs

* Add ActiveState Security Model and Considerations

* Adding examples

* Add link to ActiveState hosted OIDC docs

* Add updated docs from Andrew

* MD tweaks and some images

* Add remaining screenshots and embbed them in MD

* Tweaking instructions for publishing

* Update warehouse/templates/manage/account/publishing.html

Co-authored-by: William Woodruff <[email protected]>

* Review edit

Co-authored-by: Dustin Ingram <[email protected]>

* Review edits

Co-authored-by: Dustin Ingram <[email protected]>

* Review edits

Co-authored-by: Dustin Ingram <[email protected]>

* Review edits

Co-authored-by: Dustin Ingram <[email protected]>

* Review edits

Co-authored-by: Dustin Ingram <[email protected]>

* Translations

* Fix build script tokens, link to supported platforms

* Revise and reformat ActiveState using instructions

---------

Co-authored-by: Pete Garcin <[email protected]>
Co-authored-by: William Woodruff <[email protected]>
Co-authored-by: Dustin Ingram <[email protected]>

* Slugify tab anchors

* Add blogpost announcing more trusted publishers (#15656)

* Fix old byline

* Add blogpost announcing more trusted publishers

* Update docs/blog/posts/2024-04-20-expanding-trusted-publisher-support.md

Co-authored-by: Mike Fiedler <[email protected]>

* Apply suggestions from code review

---------

Co-authored-by: Mike Fiedler <[email protected]>

* Updating ActiveState publishing docs (#15739)

* Updating ActiveState publishing docs

* Update docs/user/trusted-publishers/using-a-publisher.md

Co-authored-by: Dustin Ingram <[email protected]>

---------

Co-authored-by: Dustin Ingram <[email protected]>

* Update publish date

* Update line for consistency

* Update tabbed headings to not appear in ToC

* Wrap long lines

* Consistency fix

* Line break

* Strip out leading $

* Make note conform

* Translations

* Add border to images

* Update screenshot

* Dark mode CSS doesn't work as expected

* Add alt text

* Update publication date

* Fix ActiveState getting started Trusted Publisher links (#15801)

* Fix ActiveState getting started Trusted Publisher links

* REALLY fix ActiveState getting started Trusted Publisher links

---------

Signed-off-by: William Woodruff <[email protected]>
Co-authored-by: William Woodruff <[email protected]>
Co-authored-by: Facundo Tuesca <[email protected]>
Co-authored-by: William Woodruff <[email protected]>
Co-authored-by: Carey Hoffman <[email protected]>
Co-authored-by: Pete Garcin <[email protected]>
Co-authored-by: Mike Fiedler <[email protected]>
Co-authored-by: Pete Garcin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants