Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement an AdminFlag for halting project/release modifications #3218

Closed
di opened this issue Mar 10, 2018 · 4 comments · Fixed by #6518
Closed

Implement an AdminFlag for halting project/release modifications #3218

di opened this issue Mar 10, 2018 · 4 comments · Fixed by #6518
Assignees
@di
Labels
admin Features needed for the Admin UI (people running the site) feature request good first issue This issue is ideal for first-time contributors! help needed We'd love volunteers to advise on or help fix/implement this.
Milestone
Package signing &...

Comments

@di
Copy link
Member

di commented Mar 10, 2018

Similar to #2967, we should implement an AdminFlag that allows us to:

  • halt all new uploads
  • prevent release/project deletion
@di di added the admin Features needed for the Admin UI (people running the site) label Mar 10, 2018
@brainwane
Copy link
Contributor

As with the other spam-related features, I'm leaving this out of the milestone bucketing since it isn't pertinent specifically to the MOSS grant.

@di di self-assigned this Mar 21, 2018
@brainwane brainwane added good first issue This issue is ideal for first-time contributors! help needed We'd love volunteers to advise on or help fix/implement this. labels Jun 20, 2019
@brainwane brainwane mentioned this issue Jun 21, 2019
Open
@calvin
Copy link
Contributor

calvin commented Aug 23, 2019 •
edited
Loading

2 new admin flags:

  • Disallow uploads
  • Disallow release AND project deletion

@calvin
Copy link
Contributor

calvin commented Aug 23, 2019 •
edited
Loading

@di It looks like disallowing uploads is already implemented in #3393. Can you confirm the requirements?

calvin pushed a commit to calvin/warehouse that referenced this issue Aug 23, 2019
@seyeong
Add disallow deletion AdminFlag
b572d0b 
See pypi#3218
@calvin calvin mentioned this issue Aug 23, 2019
Merged
@di
Copy link
Member Author

di commented Aug 23, 2019

@calvin #3393 prevents any database writes at all (e.g., you can't change your display name, etc.) where here a "halt all new uploads" flag means that just new uploads are prevented.

calvin pushed a commit to calvin/warehouse that referenced this issue Sep 9, 2019
@seyeong
Add disallow deletion AdminFlag
1858eaa 
See pypi#3218
calvin pushed a commit to calvin/warehouse that referenced this issue Sep 10, 2019
@seyeong
Add disallow deletion AdminFlag
26a79b7 
See pypi#3218
ewdurbin pushed a commit that referenced this issue Sep 12, 2019
@calvin @ewdurbin
Add disallow deletion AdminFlag (#6518)
30f2389 
* Add AdminFlagValue

* Add disallow deletion AdminFlag

See #3218

* Add disallow new upload AdminFlag

* Convert `AdminFlagValue` to enum
woodruffw pushed a commit to trail-of-forks/warehouse that referenced this issue Sep 16, 2019
@calvin @woodruffw
Add disallow deletion AdminFlag (pypi#6518)
87e1017 
* Add AdminFlagValue

* Add disallow deletion AdminFlag

See pypi#3218

* Add disallow new upload AdminFlag

* Convert `AdminFlagValue` to enum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@di di

Labels
admin Features needed for the Admin UI (people running the site) feature request good first issue This issue is ideal for first-time contributors! help needed We'd love volunteers to advise on or help fix/implement this.
Projects
None yet
Milestone
Package signing & detection/verification
Development

Successfully merging a pull request may close this issue.

Add disallow deletion AdminFlag calvin/warehouse
3 participants
@calvin @di @brainwane