Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend build instead of invoking setup.py directly #439

Merged
merged 3 commits into from
Jan 11, 2022

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Jan 10, 2022

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #439 (d98afff) into main (0e07002) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #439   +/-   ##
=======================================
  Coverage   67.57%   67.57%           
=======================================
  Files          12       12           
  Lines         916      916           
=======================================
  Hits          619      619           
  Misses        297      297           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e07002...d98afff. Read the comment docs.

docs/quickstart.rst Outdated Show resolved Hide resolved
docs/user_guide.rst Outdated Show resolved Hide resolved
@agronholm agronholm merged commit ab82cea into pypa:main Jan 11, 2022
@agronholm
Copy link
Contributor

Thanks!

@hugovk hugovk deleted the dont-call-setup.py-directly branch January 11, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should the docs promote pip wheel . over python setup.py bdist_wheel?
2 participants