style: pre-commit additions, remove <3.7 code#432
Conversation
Codecov Report
@@ Coverage Diff @@
## main #432 +/- ##
==========================================
+ Coverage 66.88% 67.03% +0.14%
==========================================
Files 11 11
Lines 897 904 +7
==========================================
+ Hits 600 606 +6
- Misses 297 298 +1
Continue to review full report at Codecov.
|
|
Just one question: is there a pre-commit check now in place that automatically injects |
|
No, that's still manual. Once it's in, pyupgrade will make sure the annotations are modern. Honestly, it probably can be done with |
d47e583 to
5bfe3d9
Compare
|
Okay, now isort enforces |
|
Thanks! |
|
This would break builds on python 3.6, which is still widely used on CentOS 7 and Ubuntu 18.04 |
|
That's the point of |
Added pyupgrade and flake8-bugbear to pre-commit configuration. Converted all code to py37+ syntax. Reformatted the pre-commit configuration file.
Added pyupgrade and flake8-bugbear to pre-commit configuration. Converted all code to py37+ syntax. Reformatted the pre-commit configuration file.
This adds some pre-commit checks, flake8-bugbear, and most importantly, pyupgrade. I've also run isort's
from __future__ import annotationsinjection to allow pyupgrade to further clean up annotations. I've also normalized the indentation of the pre-commit yaml file, it was different for each check.