-
Notifications
You must be signed in to change notification settings - Fork 182
macosx platform tag do not support minor bugfix release #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
3e213af
1a907d3
0dd9f3e
25c8fb6
80eac7b
b1f3999
496c5c6
b66add5
0570084
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -139,17 +139,15 @@ def calculate_macosx_platform_tag(archive_root, platform_tag): | |
| for filename in filenames: | ||
| if filename.endswith('.dylib') or filename.endswith('.so'): | ||
| lib_path = os.path.join(dirpath, filename) | ||
| versions_dict[lib_path] = extract_macosx_min_system_version(lib_path) | ||
| min_ver = extract_macosx_min_system_version(lib_path) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the last field of the version tuple is irrelevant to the compatibility question? If so, should it be moved up here i.e.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It need changes in more places. I push this changes in separate commit.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
| if min_ver is not None: | ||
| versions_dict[lib_path] = min_ver | ||
|
|
||
| if len(versions_dict) > 0: | ||
| base_version = max(base_version, max(versions_dict.values())) | ||
|
|
||
| if base_version[-1] == 0: | ||
| fin_base_version = base_version[:-1] | ||
| else: | ||
| fin_base_version = base_version | ||
|
|
||
| fin_base_version = "_".join([str(x) for x in fin_base_version]) | ||
| # macosx platform tag do not support minor bugfix release | ||
| fin_base_version = "_".join([str(x) for x in base_version[:-1]]) | ||
| if start_version < base_version: | ||
| problematic_files = [k for k, v in versions_dict.items() if v > start_version] | ||
| problematic_files = "\n".join(problematic_files) | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.