Replace ty: ignore with proper type declarations for inheritance patterns - #3034
Merged
gaborbernat merged 1 commit intoFeb 15, 2026
Merged
Conversation
rahuldevikar
force-pushed
the
users/rahuldevikar/fix-ty-inheritance
branch
from
February 14, 2026 23:01
8362bf3 to
8ca4c43
Compare
rahuldevikar
marked this pull request as ready for review
February 14, 2026 23:25
This was referenced Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several base classes used attributes that are only defined in subclasses (via mixins). ty couldn't see those attributes from the base class perspective, so we had
ty: ignore[unresolved-attribute]andty: ignore[not-iterable]comments.Type checkers analyze each class in isolation. When
DescribeprovidesexebutCreatoraccessesself.exe, the checker doesn't see the connection because they're only combined at the concrete class level. Our fix was to add property stubs in the base classExtension work of: #3029
Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)
tox -e fix)docs/changelogfolder