fix building python3.10 virtualenvs on debian derivatives #2415
Conversation
this fixes building a virtualenv when python3-distutils is not installed (or when not using the deadsnakes fork)
|
The thing is if we fix this we remove all incentive for Debian to fix their broken patch and we'll be in forever patching out stuff to fix their stuff. I'm not too comfortable going down that road... |
|
it's not an issue in 3.11+ at least -- and they've ignored it thus far :S |
|
Hi, can you point me at any bugs related to this that were filled on bugs.debian.org? |
| elif sys.version_info[:2] == (3, 10) and "deb_system" in scheme_names: | ||
| self.sysconfig_scheme = "posix_prefix" | ||
| self.sysconfig_paths = { | ||
| i: sysconfig.get_path(i, expand=False, scheme=self.sysconfig_scheme) for i in sysconfig.get_path_names() | ||
| } | ||
| # we cannot use distutils at all if "venv" exists, distutils don't know it |
There was a problem hiding this comment.
This comment here kinda stopped making sense in the context of the elif branch.
That's not the direct reason. We ignored the patch because it introduced the I didn't realise that upstream virtualenv was broken, here, because we had our This patch seems reasonable. |
this fixes building a virtualenv when python3-distutils is not installed (or when not using the deadsnakes fork)
I tried unsuccessfully to get debian and ubuntu to patch this and I'm sick of getting reports in pre-commit about this 😭
resolves #2340
resolves #2350
Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)!
tox -e fix_lint)docs/changelogfolder