Skip to content

Conversation

@AWhetter
Copy link
Contributor

@AWhetter AWhetter commented Apr 8, 2021

  • ran the linter to address style issues (tox -e fix_lint)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

The conversations on gitter are being redirected to the new location on Discord. Therefore this change makes the issue page point directly to the Discord link instead of users needing to go through gitter first.

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #2089 (aea876b) into main (0262fa6) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Current head aea876b differs from pull request most recent head 761a4a7. Consider uploading reports for the commit 761a4a7 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2089      +/-   ##
==========================================
- Coverage   93.70%   93.61%   -0.10%     
==========================================
  Files          88       88              
  Lines        4383     4383              
==========================================
- Hits         4107     4103       -4     
- Misses        276      280       +4     
Flag Coverage Δ
tests 93.61% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/virtualenv/util/path/_sync.py 89.65% <0.00%> (-3.45%) ⬇️
src/virtualenv/util/subprocess/_win_subprocess.py 93.84% <0.00%> (-1.54%) ⬇️
src/virtualenv/create/creator.py 95.41% <0.00%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0262fa6...761a4a7. Read the comment docs.

@gaborbernat gaborbernat merged commit 3f41067 into pypa:main Apr 8, 2021
@AWhetter AWhetter deleted the discord_issue_link branch April 8, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants