-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in setup.cfg #1858
Fix typo in setup.cfg #1858
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1858 +/- ##
==========================================
- Coverage 88.84% 88.77% -0.08%
==========================================
Files 82 82
Lines 3946 3946
==========================================
- Hits 3506 3503 -3
- Misses 440 443 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@gaborbernat please LGTM |
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good. Thanks
Give me 5 mintues. |
Sorry for that guys, my mistake, fix out under https://pypi.org/project/virtualenv/20.0.23/ |
Doesn't look that good to me... the fact that a test hasn't been introduced won't stop this from happening again. |
@fj-sanchez The entire testsuite failed because of this bug, and it was still released; adding another test isn't gonna make much difference... |
Ok, I didn't realise that was the case. Why isn't enforced a pass on all the tests? |
I think this makes a nice case study in why it's good practice to do automated releases from CI.. after tests pass |
Just to sum up the discussion:
I'm deeply sorry that this affected everyone's Friday, lessons learned and hope this will not happen again going ahead. Just for context, this was my 42nd release of this project throughout the last 2 years. I think this was the first truly broken release and hope to stay as such for at least another 100. |
Closes #1857
tox -e fix_lint
)docs/changelog
folder