Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not allow PYVENV_LAUNCHER to be set #1749

Merged
merged 1 commit into from
Mar 25, 2020
Merged

do not allow PYVENV_LAUNCHER to be set #1749

merged 1 commit into from
Mar 25, 2020

Conversation

gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented Mar 24, 2020 •
edited
Loading

Resolves #1704.

cc @nsoranzo

nsoranzo added a commit to nsoranzo/bioblend that referenced this pull request Mar 24, 2020
@nsoranzo
Test pypa/virtualenv#1749
ec7cdf8
nsoranzo
nsoranzo approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@nsoranzo nsoranzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works both in the debug and the real settings, thanks a lot!

@gaborbernat gaborbernat merged commit 7654e4d into pypa:master Mar 25, 2020
@gaborbernat gaborbernat deleted the 1704 branch March 25, 2020 09:29
@gaborbernat gaborbernat mentioned this pull request Apr 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsoranzo nsoranzo nsoranzo approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

conda commands as Python3 subprocesses inside a virtualenv fail under macOS
2 participants
@gaborbernat @nsoranzo