fix system executable discovery #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
reviewed
Feb 10, 2020
src/virtualenv/create/creator.py
Outdated
| @@ -131,7 +131,7 @@ def non_write_able(dest, value): | |||
| # pre 3.6 resolve is always strict, aka must exists, sidestep by using os.path operation | |||
| dest = Path(os.path.realpath(raw_value)) | |||
| else: | |||
| dest = value.resolve() | |||
| dest = value.absolute().resolve() # on Windows absolute does not imply resolve so use both | |||
There was a problem hiding this comment.
absolute() is undocumented (see bpo-29688)
There was a problem hiding this comment.
There was a problem hiding this comment.
It works in practice though, so I'm fine with this approach for now 🤔
There was a problem hiding this comment.
ugh, reading up that thread I've swapped to os.path.abspath now 🤷♂
There was a problem hiding this comment.
Also relevant is bpo-39090 - "getting the absolute path is surprisingly subtle and varied depending on your needs" 🙁
Signed-off-by: Bernat Gabor <[email protected]>
Signed-off-by: Bernat Gabor <[email protected]>
Signed-off-by: Bernat Gabor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might fix our test suite now.
Resolves #1552
Resolves #1553