Why I read « Helper script to rebuild virtualenv.py from virtualenv_support » in comment but the code don't use virtualenv_support folder content ?

[harobed]

Hi,

in this comment I read « Helper script to rebuild virtualenv.py from virtualenv_support » https://github.com/pypa/virtualenv/blob/develop/bin/rebuild-script.py but this code don't embed virtualenv_support folder but virtualenv_embedded folder.

I suggest to embed also virtualenv_support folder content in virtualenv.py or/and in virtualenv bootstrap http://www.virtualenv.org/en/latest/#creating-your-own-bootstrap-scripts

What do you think about ?

Best regards,
Stephane

[pfmoore]

You're right - the comment should say virtualenv_embedded.

Historically, virtualenv_support could not be embedded in the same way, because it included the setuptools eggs, which were installed using easy_install, which has to have the eggs as files in the filesystem (and there's no point in embedding the files just to write them back to the filesystem each time we run virtualenv).

Currently the support files are just sdists, which we unpack to the filesystem and install from there. In principle we could unpack direct from the embedded form, so it's possible (but fiddley). I'm not sure how much benefit there would be, though.

And longer term, we might want to switch to using wheels rather than sdists, at which point we'd need to see whether embedding is viable and has any benefits all over again.

So basically, I'm interested in the idea, but I doubt there's enough gain to be had to make it worthwhile. If you're interested enough to create a patch, I'll review it, but even then I'm afraid I'm not willing to promise that it will be accepted. But I will think about this some more, and who knows, I may become more enthusiastic...

Thanks for the interesting suggestion.

[dstufft]

One benefit to not embedding them is it makes it easier for the Linux distros to put them in a more proper place. If that's something we care about I don't know.

[pnasrat]

From my perspective we should be considerate of downstream packaging.

Paul

On 19 August 2013 15:18, Donald Stufft [email protected] wrote:

One benefit to not embedding them is it makes it easier for the Linux
distros to put them in a more proper place. If that's something we care
about I don't know.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/464#issuecomment-22897147
.

[harobed]

Proposition instead embed setuptools and pip in virtualenv : #465

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Just add a comment if you want to keep it open. Thank you for your contributions.