Update test to honor new behavior in importlib_metadata 8.7 #4962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I started looking into specifically trapping the error and replacing it with an OptionError, but ultimately I decided that would add too much complication, and the whole point of validating the error in importlib metadata is so that other libraries don't have to do so, so I've instead marked the validation routine as deprecated in favor of eventual retirement when importlib_metadata 8.7 or later (and its stdlib equivalent) are available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4961
Summary of changes
Closes
Pull Request Checklist
newsfragments/.(See documentation for details)