Add fake __getattribute__ to AbstractSandbox to let type-checkers know it has a bunch of dynamic methods #4708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Follow-up to #4504, works towards #2345
Given that
AbstractSandbox
isn't even public API (afaik) and that the methods are created based on os availability, I figured simply marking it as "having dynamically created methods" was cleaner than trying to duplicate all the methods in aTYPE_CHECKING
block like https://github.com/python/typeshed/pull/10058/files#diff-f3cbc40d076f82bceeedca2749a2d93fbb40a03e1bb4bc837de6e990823e381fR29-R56 (typeshed doesn't have any of these methods typed anyway)This trades false-positives if trying to call one of these methods directly, for false-negatives if you try to call an
AbstractSandox
method that doesn't exist.Pull Request Checklist
newsfragments/
. (this shouldn't affect runtime in any way)(See documentation for details)